Repository navigation
fix(web): the product page shows specs and reviews before prices and sellers - #1535
Conversation
…sellers The product comes first: after the hero and scoreboard the page reads the spec groups, then the reviews, the price history, and the sellers last. The jump row follows the same order. It stays in the phone's first screen (#1517), as does the price strip with the best price. The unknown-size listings stay with the sellers. The item pages share this view, so they follow too. Closes #1530 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ReviewFresh-context review of 84b5d49: no significant finding.
Codex round 1: nothing significant. No second round was needed. Product note for the PO: on a phone, the "Nơi bán (N)" chip is now last in the jump row, past its right-edge fade, so it takes a swipe to reach. This follows from the #1530 order. The best price stays in the price strip in the first screen. |
Closes #1530
JOY asked for the product information and specs to sit above the price history and the sellers.
What
Product page order (
smartphones/[slug]/page.tsx, shared by every category and the Item pages):#specs-section);#jreviews-section);#pdv-price-history);#offers-table), with the unknown-size listings group right after them.Before this change the order after the hero was sellers, price history, specs, then reviews (#1469).
Tests
e2e/product-section-order.spec.tsande2e/item-model/item-product-page.spec.tsassert the new order:core-rate-architecturechecks the source order: specs, then<JReviewsSection, then#pdv-price-history, then#offers-table.product-above-fold.spec.tsstill checks that the whole jump row is in the first screen at 390x844 and 375x812. It needs no change, since the row did not move.core-rate-architecturepass locally.Coordination
PR #1534 (#1528, stars) also touches this page, but only the scoreboard and the hero score line, not these sections. Whichever lands second gets a trivial rebase.
Review
To follow in the comments: a fresh-context review and Codex.
🤖 Generated with Claude Code
📌 TL;DR
This PR reorders the sections on the smartphone product detail page to prioritize product specifications and reviews over merchant offers and price history, aligning the UI with the new "product-first" design requirement (#1530). It updates the visual layout, navigation jump links, and corresponding E2E and architectural tests to reflect the new sequence.
🎯 Type of Change
🔍 Changes Walkthrough
apps/web/e2e/item-model/item-product-page.spec.tsORDERto match the new layout (Specs → Reviews → History → Offers).apps/web/e2e/product-section-order.spec.tsORDERconstant to verify the new "specs first" sequence.apps/web/src/app/[locale]/smartphones/[slug]/page.tsx#specs-sectionand#jreviews-sectionblocks to the top of the content area. Moved#pdv-price-historyand#offers-table(including unknown size offers) to the bottom. Updated thenavjump links to reflect the new order.apps/web/src/server/rate/__tests__/core-rate-architecture.test.ts#specs-section<<JReviewsSection /><#pdv-price-history<#offers-table.📊 Architectural Flow
flowchart TD subgraph "Product Detail Page (New Order)" A[Price Box / Scoreboard] --> B[Jump Nav] B --> C[#specs-section] C --> D[#jreviews-section] D --> E[#pdv-price-history] E --> F[#offers-table] F --> G[Unknown Size Offers] end subgraph "Old Order (Removed)" H[#offers-table] --> I[#pdv-price-history] I --> J[#specs-section] J --> K[#jreviews-section] end style C fill:#e1f5fe,stroke:#01579b style D fill:#e1f5fe,stroke:#01579b style E fill:#fff9c4,stroke:#fbc02d style F fill:#fff9c4,stroke:#fbc02d