Skip to content

feat: monitor rate.vn home, health and public API - #5

Merged
JOY (JOY) merged 1 commit into
masterfrom
claude/rate-vn-monitors
Oct 24, 2026
Merged

JOY (JOY) merged 1 commit into
masterfrom
claude/rate-vn-monitors

Conversation

@JOY

@JOY JOY (JOY) commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Adds three Upptime sites for rate.vn, which had no monitor:

Why: on 2026-10-24 the Supabase legacy keys were disabled and rate.vn returned 500 for about 2 h 50 min with no alert (DOS/Rate#814).

All three URLs return 200 with user-agent DOS, and so does the icon https://rate.vn/img/rate-logo-64.png.

Approved by JOY in chat on 2026-10-24.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added uptime monitoring for the Rate.vn website, API stats, and health endpoints, with response-time limits for each.

Adds three Upptime sites for rate.vn. /api/health now returns 503 when
the Supabase read fails (DOS/Rate#829), so a database outage like the
one on 2026-10-24 (DOS/Rate#814) opens a status issue.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization has no extra usage available to pay for this review.

If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.

Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c7948363-7090-4329-b63b-b1ec2b3dc60a
Commits

Reviewing files that changed from the base of the PR and between a497f99 and 23ed2a8.

Files selected for processing: 1
  • .upptimerc.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The uptime configuration adds checks for the Rate.vn site root, health endpoint, and API stats endpoint. Each check has a response-time limit.

Changes: Rate.vn uptime checks

Layer / File(s) Summary
Configure Rate.vn endpoint checks
.upptimerc.yml
Adds checks for the site root and API stats endpoint with 5,000 ms limits, and for the health endpoint with a 10,000 ms limit. A comment notes possible health-check 503 responses and cold starts of up to about 9 seconds.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Merge Risk: Minimal · up to 23ed2

The three monitors and their response-time thresholds are ready to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "feat: monitor rate.vn home, health and public API" matches the main change. The raw summary shows three Rate.vn uptime checks added to .upptimerc.yml: the site root, the health endpoint, an…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "feat: monitor rate.vn home, health and public API" matches the main change. The raw summary shows three Rate.vn uptime checks added to .upptimerc.yml: the site root, the health endpoint, and the API stats endpoint. The objectives confirm the same three monitors. The title names the subject (rate.vn), the three monitored surfaces, and the change type (feat). It omits the response-time thresholds, which is acceptable because the title need not cover every detail.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

dos[bot]
dos Bot approved these changes Oct 24, 2026

@dos dos Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱️ Code Review completed (1 eligible files · 778 chars · 1 model call(s) · 1 PR unit(s))

Whole diff with bounded context at base a497f99 / head 23ed2a8.

✅ CLEAN_PASS: Complete diff reviewed

@JOY
JOY (JOY) merged commit 7f6bef8 into master Oct 24, 2026
5 of 6 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds three new endpoints for Rate.vn to the Upptime configuration file. The review feedback suggests increasing the maxResponseTime threshold to 15000 ms for both the health and API endpoints to safely accommodate serverless cold starts and avoid false-positive downtime alerts.

Comment thread .upptimerc.yml
- name: Rate.vn Health
url: https://rate.vn/api/health
icon: https://rate.vn/img/rate-logo-64.png
maxResponseTime: 10000

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment on line 50 notes that cold starts can take up to ~9 seconds. Setting maxResponseTime to 10000 (10 seconds) leaves a very narrow margin of only 1 second. Under slight network jitter or platform load, cold starts can easily exceed 10 seconds, leading to false-positive downtime alerts. It is recommended to increase this threshold to 15000 (15 seconds) to provide a safe buffer and prevent alert fatigue.

    maxResponseTime: 15000

Comment thread .upptimerc.yml
- name: Rate.vn API
url: https://rate.vn/api/v1/rate/stats
icon: https://rate.vn/img/rate-logo-64.png
maxResponseTime: 5000

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since the Rate.vn API endpoint (/api/v1/rate/stats) is also a serverless API route that queries the database, it will be subject to the same Vercel cold start delays (up to ~9 seconds) as the health endpoint. Setting maxResponseTime to 5000 (5 seconds) will highly likely trigger false-positive alerts on cold starts. It is recommended to increase this threshold to 15000 (15 seconds) to accommodate cold starts safely.

    maxResponseTime: 15000

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .upptimerc.yml configuration file to add monitoring for three new endpoints: Rate.vn, Rate.vn Health, and Rate.vn API, specifying their URLs, icons, and maximum response times. There are no review comments, and I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant