Skip to content

Rewrite the Readme!#20

Open
illwieckz wants to merge 1 commit into
masterfrom
illwieckz/readme
Open

Rewrite the Readme!#20
illwieckz wants to merge 1 commit into
masterfrom
illwieckz/readme

Conversation

@illwieckz

@illwieckz illwieckz commented Jun 22, 2026

Copy link
Copy Markdown
Member

Google will no longer update it, we fully adopt this!

This is now our Readme!

@illwieckz

Copy link
Copy Markdown
Member Author

@slipher I would like to know the current status of this sentence:

Currently it only works for amd64 host+target (run.py won't work since NaCl targets aren't supported yet).

Comment thread README.md
- `src/trusted/`: Source code that's used only by trusted code
- `src/untrusted/`: Source code that's used only by untrusted code
- `tests/common/`: Source code for examples and tests.
- `../third_party/`: Third-party source code and binaries that aren't part of

@illwieckz illwieckz Jun 22, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can delete this ../third_party mention. The first purpose of the fork was to not require things outside this repository.

@slipher

slipher commented Jun 22, 2026

Copy link
Copy Markdown
Member

@slipher I would like to know the current status of this sentence:

Currently it only works for amd64 host+target (run.py won't work since NaCl targets aren't supported yet).

Oh that's out of date indeed. NaCl targets work great. You can built NaCl targets, including the IRT, and test everything together. That's why I complain that using CMake is a regression, since it can't handle the multiple toolchains working in concert. I have verified that Linux stuff generally works and tests pass on the x86_64, x86, and (modulo recent kernel changes...) arm platforms.

@slipher

slipher commented Jun 22, 2026

Copy link
Copy Markdown
Member

I haven't tested Windows or Mac yet. But I know that run.py works on at least some Linux targets.

Comment thread README.md

## Dependencies

- LLVM (must be installed in `/usr/bin`)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slipher do we still need LLVM be in /usr/bin/?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to rewrite this line as GCC or Clang.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the LLVM location is still hard-coded. GCC just needs to be in the PATH. And with the other PR LLVM is now optional.

@illwieckz

Copy link
Copy Markdown
Member Author

Currently it only works for amd64 host+target (run.py won't work since NaCl targets aren't supported yet).
Oh that's out of date indeed. NaCl targets work great. You can built NaCl targets, including the IRT, and test everything together.

Great.

That's why I complain that using CMake is a regression, since it can't handle the multiple toolchains working in concert.

CMake can totally use a different toolchain per ExternalProject, and an ExternalProject can build a local directory. This is what we do to build nexe game with PNaCl/Saigo for Unvanquished…

The reason why my CMake implementation doesn't care about IRT right now is that the first goal is to give the ability to build native trusted binaries from Dæmon's external_deps and to extend the compatibility of that (MinGW, etc.).

IRT can be downloaded for now, built with SCons in advance. I'm not excluding the opportunity to build the IRT too, but this is not needed to reach the minimal valuable product which is to make the native loader binary buildable with CMake with the exact same ease we do with the engine itself.

It's totally on purpose that IRT isn't cared about yet, that's a selling point: I don't want the IRT topic to hold back the CMake implementation. The fact the current CMake implementation doesn't build the IRT should not be used against the CMake implementation. It would be holding it back because of the special effort made to not hold it back.

I don't mind that tests remain implemented in SCons forever, run by a CI or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants