Skip to content

Ignore static properties in parameter objects #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alaricd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ignore static properties in parameter objects #2254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Dapper/SqlMapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2601,12 +2601,12 @@ private static bool IsValueTuple(Type? type) => (type?.IsValueType == true

var allTypeProps = type.GetProperties();
var propsList = new List<PropertyInfo>(allTypeProps.Length);
for (int i = 0; i < allTypeProps.Length; ++i)
{
var p = allTypeProps[i];
if (p.GetIndexParameters().Length == 0)
propsList.Add(p);
}
for (int i = 0; i < allTypeProps.Length; ++i)
{
var p = allTypeProps[i];
if (p.GetIndexParameters().Length == 0 && p.GetMethod?.IsStatic != true)
propsList.Add(p);
}

var ctors = type.GetConstructors();
ParameterInfo[] ctorParams;
Expand Down
1 change: 1 addition & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
<PackageVersion Include="Norm.net" Version="5.4.0" />
<PackageVersion Include="Npgsql" Version="10.0.2" />
<PackageVersion Include="PetaPoco" Version="5.1.306" />
<PackageVersion Include="pengdows.crud.fakeDb" Version="2.0.5" />
<PackageVersion Include="RepoDb.SqlServer" Version="1.13.1" />
<PackageVersion Include="ServiceStack.OrmLite.SqlServer" Version="10.0.6" />
<PackageVersion Include="Snowflake.Data" Version="5.5.0" />
Expand Down
5 changes: 3 additions & 2 deletions tests/Dapper.Tests/Dapper.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,9 @@
<PackageReference Include="log4net" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' != 'net481'">
<PackageReference Include="Npgsql" />
<ItemGroup Condition="'$(TargetFramework)' != 'net481'">
<PackageReference Include="pengdows.crud.fakeDb" />
<PackageReference Include="Npgsql" />
<PackageReference Include="Snowflake.Data" />
</ItemGroup>

Expand Down
31 changes: 31 additions & 0 deletions tests/Dapper.Tests/FakeDbTests.Issue621.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
#if !NET481
using pengdows.crud.fakeDb;
using Xunit;

namespace Dapper.Tests
{
public sealed class FakeDbIssue621Tests
{
[Fact]
public void StaticPropertiesAreIgnoredWhenCreatingParameters()
{
using var conn = new fakeDbConnection(new FakeDataStore());
conn.EnqueueNonQueryResult(1);
conn.Open();

var parameters = new Parameters { InstanceValue = "instance" };
Parameters.StaticValue = "static";

var result = conn.Execute("select @InstanceValue, @StaticValue", parameters);

Assert.Equal(1, result);
}

private sealed class Parameters
{
public string? InstanceValue { get; set; }
public static string? StaticValue { get; set; }
}
}
}
#endif