Repository navigation
Fix artifact poisoning in gen-release-pr workflow - #470
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
doron050
added
the
skip-release
Contributor
Release Assistant - PassedPR marked as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes code scanning alert #1 (
actions/artifact-poisoning/critical).On
workflow_dispatch,dawidd6/action-download-artifactgot an emptyrun_idand could fall back to an artifact from an arbitrary run (e.g. a PR/fork build). Thatplugin.wasmis then hashed and written into the release docs.Changes: replaced the third-party action with
gh run downloadfrom an explicitly resolved run id. The run must be a successfulpushbuild onmainin this repo (taken from theworkflow_runevent, or the latest such run for manual dispatch). The step fails if none is found.🤖 Generated with Claude Code