Repository navigation
Conversation
…x, useCancellationToken Old names stay as deprecated aliases; conflicting values are rejected. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Use the new option names in the useAsyncEnumerable code and examples, and document useAsyncEnumerable in AGENTS.md. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
doron050
added
the
minor
Contributor
Release Assistant - PassedAll requirements satisfied. Release Information:
This PR is ready to merge. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #373 (naming standardization).
Renames
overrideDriverVersiondriverVersionoverrideDapperVersiondapperVersionwithAsyncSuffixuseAsyncSuffixwithCancellationTokenuseCancellationTokenConvention:
use*for behaviours,generate*for artifacts,*Versionfor version pins.overrides,namespaceNameanddebugRequestare intentionally unchanged.Compatibility
ArgumentException.Options..cs/.csprojoutput is unchanged; onlyrequest.*files change (re-serialised options).Also
useAsyncEnumerablealready follows the convention. Its code and examples now use the new names, and it is documented inAGENTS.md.Testing
make unit-tests: 12 + 143 pass.make test-plugin: 275/279 end-to-end pass. The 4 failures (MySQLTestFloatingPointCopyFrom/TestIntegerCopyFrom) fail identically on cleanmain.🤖 Generated with Claude Code