Skip to content

fix(share): preserve Android attachments with duplicate filenames #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dn-presence merged 1 commit into from
Oct 1, 2026
Merged

fix(share): preserve Android attachments with duplicate filenames #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions plugins/dartnative_share/android/src/main/kotlin/com/dartnative/share/DNShareBridge.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ private fun chooserFor(target: Intent, token: Long?): Intent {
* this becomes the photo/video caption.
*
* Each file is copied into the app's cache dir
* (`cacheDir/dn_share/<basename>`) and vended via `FileProvider` so the
* (`cacheDir/dn_share/<index>/<basename>`) and vended via `FileProvider` so the
* receiving app can read it. The cache dir is cleared on every call.
*/
@Keep
Expand Down Expand Up @@ -220,14 +220,17 @@ private fun shareFilesImpl(

val authority = providerAuthority(ctx)
val uris = ArrayList<Uri>(paths.size)
for (path in paths) {
for ((index, path) in paths.withIndex()) {
if (path.isEmpty()) continue
val src = File(path)
if (!src.exists()) {
Log.w(TAG, "shareFiles: source file does not exist: $path")
continue
}
val dest = File(cacheDir, src.name)
// Preserve the filename without colliding with another source.
val attachmentDir = File(cacheDir, index.toString())
attachmentDir.mkdirs()
val dest = File(attachmentDir, src.name)
src.copyTo(dest, overwrite = true)
uris += FileProvider.getUriForFile(ctx, authority, dest)
}
Expand Down Expand Up @@ -341,5 +344,5 @@ private fun startChooser(chooser: Intent) {

private fun clearDir(dir: File) {
if (!dir.exists()) return
dir.listFiles()?.forEach { it.delete() }
dir.listFiles()?.forEach { it.deleteRecursively() }
}