Repository navigation
Split BYOC component workloads behind a workload interface - #3656
Open
shuheiktgw wants to merge 1 commit into
Open
shuheiktgw wants to merge 1 commit into
shuheiktgw wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎯 Code Coverage (details) 🔗 Commit SHA: d5b54d8 | Docs | View more details | Give us feedback! |
shuheiktgw
force-pushed
the
shuheiktgw/refactor_byoc_component_workload
branch
from
October 23, 2026 13:08
c6c6186 to
9280dc0
Compare
Replace the Deployment/StatefulSet-specific fields of component with a workload interface implemented by deploymentWorkload and statefulSetWorkload, and precompute component-specific environment variables into extraEnv.
shuheiktgw
force-pushed
the
shuheiktgw/refactor_byoc_component_workload
branch
from
October 23, 2026 14:24
9280dc0 to
d5b54d8
Compare
shuheiktgw
commented
Oct 23, 2026
| // decommissionTimeoutEnv is set to a fraction of the termination grace period. | ||
| decommissionTimeoutEnv string | ||
| // workload renders the controller running the pods of a component. | ||
| type workload interface { |
Contributor
Author
There was a problem hiding this comment.
The name workload is a bit awkward here since we already have workload.go, but I don't want to rename files as it would create too many diffs for this small improvement. I'll clean it up in a separate PR.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors how BYOC components are rendered in
internal/controller/datadogbyoccluster/resources. There is no behavior change.componentno longer carries fields that only make sense for some components (stateful,strategy,database,databaseURIEnv,decommissionTimeoutEnv).workloadinterface has two implementations:deploymentWorkloadindeployment.goandstatefulSetWorkloadinstateful_set.go. They own the workload specific configurations.components()now builds the component-specific environment variables (metastore database URI, decommission timeouts) up front intoextraEnv.component.env()is gone.Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel