fix(synthetics_tests): remap mobile test principals under options.bindings

[michael-richey]

Summary

• Mobile synthetic tests store access-control bindings under options.bindings.
• Principal discovery and remapping previously read restriction_policy.bindings, so organization, user, role, and team principals were not resolved before destination requests.
• Update all affected call sites to use options.bindings, alongside the existing options.restricted_roles handling.

Test plan

• Updated existing unit tests to use documented mobile-test fixtures.
• Added regression coverage for options.bindings and options.restricted_roles coexisting without a top-level restriction_policy key.
• pytest tests/unit/test_synthetics_tests.py -- 37 passed.
• tox -e py311 -- tests/unit -q -- 1103 passed, 8 skipped.
• Black and Ruff pass on the changed files.

[Copilot]

Pull request overview

This PR fixes principal remapping for synthetics_tests by updating the access-control path from a non-existent top-level restriction_policy.bindings to the correct options.bindings shape used by real Synthetics Test resources, preventing stale source-org principals from causing destination API rejections.

Changes:

• Update synthetics_tests principal-connection/remapping logic to read/write options.bindings.principals instead of restriction_policy.bindings.principals.
• Adjust pre_apply_hook policy detection to trigger org-principal fetching based on presence of options.bindings.
• Update and extend unit tests to reflect the real resource shape (no restriction_policy, options.restricted_roles and options.bindings coexisting).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
datadog_sync/model/synthetics_tests.py	Switches all principal binding paths and policy detection to options.bindings for correct remapping and drop-aware connection behavior.
tests/unit/test_synthetics_tests.py	Updates fixtures/assertions to options.bindings and adds regressions for real-world shapes without restriction_policy.

Suppressed comments (1)

tests/unit/test_synthetics_tests.py:337

• These test docstrings still refer to restriction_policy, but pre_apply_hook now keys off options.bindings. Updating the description will keep the tests aligned with the real synthetics_tests shape.

    def test_pre_apply_hook_sets_org_principal_on_success(self):
        """Source carries a restriction_policy → GET fires → org_principal set."""

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.