Repository navigation
Generate a zero-branch root for empty tries - #140
Merged
Merged
Conversation
This was referenced Oct 17, 2026
mcculls
marked this pull request as ready for review
October 17, 2026 14:22
1 task done
PerfectSlayer
approved these changes
Oct 19, 2026
mcculls
force-pushed
the
mcculls/trie-unicode-segments
branch
from
October 19, 2026 16:39
2367fab to
948af7b
Compare
Encode the empty root sentinel when generating Java source from an empty mapping, so nonempty lookups return no match instead of reading past an empty array. Generate and compile an empty trie in a regression test and exercise both lookup overloads.
mcculls
force-pushed
the
mcculls/trie-empty-generation
branch
from
October 19, 2026 16:48
19d2d70 to
a1d650a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Encode the empty root sentinel when generating Java source from an empty mapping. Both lookup overloads now return -1 for unmatched keys.
Motivation
The generator emitted an empty data array, but lookup expects a root branch count. Any nonempty lookup on the generated trie threw ArrayIndexOutOfBoundsException.
Additional Notes
The regression test generates and compiles an empty trie, then exercises both lookup overloads with empty and nonempty keys.
Stack (merge in order):
This PR targets
mcculls/trie-unicode-segments.Contributor Checklist