sds-go: unmarshal JwtClaimsValidator config - #385
Merged
Conversation
The Go bindings already constructed JwtClaimsValidator rules and sent them over FFI, but SecondaryValidator had no UnmarshalJSON, so loading a rule from JSON left Config as nested maps instead of JwtClaimsValidatorConfig. For DATASEC-201
Contributor
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
vinckama
marked this pull request as ready for review
August 28, 2026 14:27
vhourdel
approved these changes
Aug 28, 2026
| switch rawMap.Type { | ||
| case string(JwtValidatorType): | ||
| var jwtConfig JwtClaimsValidatorConfig | ||
| if err := json.Unmarshal(rawMap.Config, &jwtConfig); err != nil { |
Contributor
There was a problem hiding this comment.
This unmarshal doesn't seem to be supporting NotExpired (defined here in the Rust engine). Maybe this should be tackled in a follow up PR.
Contributor
Author
There was a problem hiding this comment.
good catch, I will add this in a follow-up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go bindings already constructed JwtClaimsValidator rules and sent them over FFI, but SecondaryValidator had no UnmarshalJSON, so loading a rule from JSON left Config as nested maps instead of JwtClaimsValidatorConfig.
For DATASEC-201