Skip to content

Debugger fix coverage#11807

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits into
masterfrom
jpbempel/fix-coverage
Jul 1, 2026
Merged

Debugger fix coverage#11807
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits into
masterfrom
jpbempel/fix-coverage

Conversation

@jpbempel

Copy link
Copy Markdown
Member

What Does This Do

fix coverage for

  • ExceptionProbeManager.ThrowableState
  • SpringHelper.ParserSpringVersion
  • SourceMapper
  • ConfigurationUpdater

Motivation

Additional Notes

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@jpbempel jpbempel requested a review from a team as a code owner June 30, 2026 13:46
@jpbempel jpbempel requested review from andreimatei and removed request for a team June 30, 2026 13:46
@dd-octo-sts

dd-octo-sts Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@jpbempel jpbempel added comp: debugger Dynamic Instrumentation comp: testing Testing tag: no release notes Changes to exclude from release notes type: refactoring labels Jun 30, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.81 s 14.67 s [+0.1%; +1.8%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.57 s 13.72 s [-2.0%; -0.2%] (maybe better)
startup:petclinic:appsec:Agent 16.93 s 16.92 s [-0.9%; +1.1%] (no difference)
startup:petclinic:iast:Agent 16.98 s 17.00 s [-0.7%; +0.5%] (no difference)
startup:petclinic:profiling:Agent 16.85 s 17.01 s [-1.9%; +0.0%] (no difference)
startup:petclinic:sca:Agent 16.94 s 16.88 s [-0.7%; +1.4%] (no difference)
startup:petclinic:tracing:Agent 16.17 s 16.07 s [-0.2%; +1.4%] (no difference)

Commit: c28eb7f4 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3

bric3 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

FYI, to enable coverage for debugger

You may need to tweak debugger test config with something like that line that enables the coverage

dd-trace-java/.gitlab-ci.yml

Lines 1034 to 1043 in d7c22a5

# specific jvms list for debugger project because J9-based JVMs have issues with local vars
# so need to test at least against one J9-based JVM
test_debugger:
extends: .test_job
variables:
GRADLE_TARGET: ":debuggerTest"
CACHE_TYPE: "base"
DEFAULT_TEST_JVMS: /^(8|11|17|21|25|semeru8)$/ # the latest "tip" version is LTS v25
parallel:
matrix: *test_matrix

script:
- if [ "$testJvm" == "8" ]; then export GRADLE_PARAMS="-PskipFlakyTests -PcheckCoverage"; fi
- !reference [.test_job, script]

@jpbempel jpbempel requested review from a team as code owners June 30, 2026 15:49
@jpbempel jpbempel requested review from AlexeyKuznetsov-DD and randomanderson and removed request for a team June 30, 2026 15:49
@pr-commenter

pr-commenter Bot commented Jun 30, 2026

Copy link
Copy Markdown

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1782922942 1782923288
end_time 2026-07-01T16:23:48 2026-07-01T16:29:34
git_branch master jpbempel/fix-coverage
git_commit_sha 602a81d c28eb7f
start_time 2026-07-01T16:22:23 2026-07-01T16:28:09
See matching parameters
Baseline Candidate
ci_job_id 1821840707 1821840707
ci_pipeline_id 122160390 122160390
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1782922263 1782922263

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-15.264µs; +21.355µs] or [-5.244%; +7.336%]
unstable
[-24.292µs; +34.596µs] or [-7.339%; +10.453%]
unstable
[-33.436µs; +46.754µs] or [-9.660%; +13.507%]
unstable
[-244.261µs; -4.259µs] or [-17.540%; -0.306%]
same
scenario:basic same same same unstable
[-367.139µs; -100.777µs] or [-26.280%; -7.214%]
same
scenario:loop unsure
[+3.227µs; +9.077µs] or [+0.036%; +0.102%]
unsure
[+4.365µs; +16.065µs] or [+0.049%; +0.179%]
same same same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (330.977 µs) : 309, 353
.   : milestone, 331,
basic (297.657 µs) : 291, 305
.   : milestone, 298,
loop (8.987 ms) : 8982, 8993
.   : milestone, 8987,
section candidate
noprobe (336.129 µs) : 303, 369
.   : milestone, 336,
basic (297.424 µs) : 290, 305
.   : milestone, 297,
loop (8.998 ms) : 8992, 9003
.   : milestone, 8998,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 330.977 µs [308.597 µs, 353.357 µs]
basic 297.657 µs [290.75 µs, 304.564 µs]
loop 8.987 ms [8.982 ms, 8.993 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 336.129 µs [303.479 µs, 368.778 µs]
basic 297.424 µs [290.296 µs, 304.552 µs]
loop 8.998 ms [8.992 ms, 9.003 ms]

@jpbempel jpbempel added this pull request to the merge queue Jun 30, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jun 30, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-30 19:48:04 UTC ℹ️ Start processing command /merge


2026-06-30 19:48:10 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-06-30 21:48:45 UTCMergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 1622620339817469906 took longer than expected. The current limit for the base branch 'master' is 120 minutes.

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 30, 2026
jpbempel added 2 commits July 1, 2026 07:11
fix coverage for
- ExceptionProbeManager.ThrowableState
- SpringHelper.ParserSpringVersion
- SourceMapper
- ConfigurationUpdater
@jpbempel jpbempel force-pushed the jpbempel/fix-coverage branch from 0e0ca30 to 8e40b6c Compare July 1, 2026 05:11
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 75.34%
Overall Coverage: 56.88% (+1.84%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c28eb7f | Docs | Datadog PR Page | Give us feedback!

@jpbempel jpbempel force-pushed the jpbempel/fix-coverage branch from 40e315f to 53a5014 Compare July 1, 2026 12:48
@jpbempel jpbempel added this pull request to the merge queue Jul 1, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 1, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-01 14:17:19 UTC ℹ️ Start processing command /merge


2026-07-01 14:17:24 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-07-01 16:11:22 UTCMergeQueue: This merge request was updated

This PR is rejected because it was updated

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 1, 2026
enable Kotlin for all JDKs
@jpbempel jpbempel enabled auto-merge July 1, 2026 16:49
@jpbempel jpbempel added this pull request to the merge queue Jul 1, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 1, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-01 17:12:32 UTC ℹ️ Start processing command /merge


2026-07-01 17:12:37 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-07-01 18:10:39 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 1, 2026
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit b710ce8 into master Jul 1, 2026
592 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the jpbempel/fix-coverage branch July 1, 2026 18:10
@github-actions github-actions Bot added this to the 1.64.0 milestone Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: debugger Dynamic Instrumentation comp: testing Testing tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants