v1: serialize span links as structured data and honor baggage tag config.#11810
Open
AlexeyKuznetsov-DD wants to merge 1 commit into
Open
v1: serialize span links as structured data and honor baggage tag config.#11810AlexeyKuznetsov-DD wants to merge 1 commit into
AlexeyKuznetsov-DD wants to merge 1 commit into
Conversation
AlexeyKuznetsov-DD
added
comp: core
dougqh
approved these changes
Jul 1, 2026
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in Use ⏳ Processing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Replaces the
v1trace payload'sCoreSpan.processTagsAndBaggage(consumer, injectLinksAsTags, injectBaggageAsTags)with a purpose-namedprocessTagsAndBaggageWithStructuredLinks(consumer):v1serializes links as first-class data and no longer flattens them into the_dd.span_linkstag (injectLinksAsTags = false).v1previously hard-codedinjectBaggageAsTags = false; it now respects the configured value, aligningv1with thev0.4/V0.5paths.CoreSpan(replaced by a default method),DDSpan,DDSpanContext, and the test doubles (SimpleSpan,TraceGenerator).On the test side:
v1coverage inDDSpanSerializationTest.java(structured links not flattened; configured baggage tags).v1decoder into a sharedV1PayloadReader, now used by bothDDSpanSerializationTestandTraceMapperV1PayloadTest.Motivation
system-testsfailed on my branch when I enabledv1by default for tests inTest_Headers_Baggage_Span_Tags.Additional Notes
Verified:
./gradlew :dd-trace-core:test --tests DDSpanSerializationTest --tests TraceMapperV1PayloadTestpasses;spotlessApplyclean.system-testspassed locally:DD_TRACE_DEBUG=true TEST_LIBRARY=java ./run.sh PARAMETRIC tests/parametric/test_headers_baggage.py --force-dd-trace-debugwith both modes:v1orv04enabled.