Skip to content

Fix netty instrumentation requirement for JDK 27#11904

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
sarahchen6/address-netty-failure
Jul 10, 2026
Merged

Fix netty instrumentation requirement for JDK 27#11904
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
sarahchen6/address-netty-failure

Conversation

@sarahchen6

@sarahchen6 sarahchen6 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Loosen netty instrumentation error check

Motivation

JDK 27 changes the socket connection-refused message from:

Connection refused: /127.0.0.1:61

to:

Connection refused (connect failed): /127.0.0.1:61

Additional Notes

Full GitLab pipeline that runs non-default JVMs, JDK 27 tests included: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/pipelines/123869235

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@sarahchen6 sarahchen6 added type: bug fix Bug fix inst: netty Netty instrumentation labels Jul 9, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.98 s 13.94 s [-0.5%; +1.1%] (no difference)
startup:insecure-bank:tracing:Agent 12.94 s 12.98 s [-1.0%; +0.4%] (no difference)
startup:petclinic:appsec:Agent 17.46 s 17.25 s [+0.1%; +2.3%] (maybe worse)
startup:petclinic:iast:Agent 17.42 s 17.50 s [-1.4%; +0.5%] (no difference)
startup:petclinic:profiling:Agent 16.78 s 17.26 s [-6.9%; +1.3%] (no difference)
startup:petclinic:sca:Agent 17.52 s 16.73 s [+0.4%; +9.1%] (maybe worse)
startup:petclinic:tracing:Agent 16.66 s 16.73 s [-1.2%; +0.4%] (no difference)

Commit: a3536b2c · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@hannahkm hannahkm marked this pull request as ready for review July 9, 2026 21:02
@hannahkm hannahkm requested a review from a team as a code owner July 9, 2026 21:02
@hannahkm hannahkm requested review from ygree and removed request for a team July 9, 2026 21:02
@PerfectSlayer PerfectSlayer added the tag: no release notes Changes to exclude from release notes label Jul 10, 2026
@sarahchen6

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 10, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-10 13:06:58 UTC ℹ️ Start processing command /merge


2026-07-10 13:07:03 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-07-10 14:08:00 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit c21ff33 into master Jul 10, 2026
982 of 987 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the sarahchen6/address-netty-failure branch July 10, 2026 14:07
@github-actions github-actions Bot added this to the 1.65.0 milestone Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: netty Netty instrumentation tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants