Skip to content

Rename span.attachWithCurrent() to span.attachWithContext()#11907

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
mcculls/span-attachwithcontext
Jul 10, 2026
Merged

Rename span.attachWithCurrent() to span.attachWithContext()#11907
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
mcculls/span-attachwithcontext

Conversation

@mcculls

@mcculls mcculls commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Rename span.attachWithCurrent() to span.attachWithContext() and prefer it over currentContext.with(span).attach()

Motivation

attachWithContext() is more understandable to new developers and agents

Contributor Checklist

Jira ticket: [PROJ-IDENT]

…r it over currentContext.with(span).attach()
@mcculls mcculls requested review from a team as code owners July 10, 2026 10:47
@mcculls mcculls removed the request for review from a team July 10, 2026 10:47
@mcculls mcculls added the comp: core Tracer core label Jul 10, 2026
@mcculls mcculls requested a review from mtoffl01 July 10, 2026 10:47
@mcculls mcculls added tag: no release notes Changes to exclude from release notes type: refactoring labels Jul 10, 2026
@mcculls mcculls requested review from PerfectSlayer, amarziali and vandonr and removed request for a team July 10, 2026 10:47

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0280f764b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@datadog-prod-us1-4

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.79 s 14.63 s [+0.2%; +2.0%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.58 s 13.74 s [-1.9%; -0.4%] (maybe better)
startup:petclinic:appsec:Agent 16.25 s 16.91 s [-8.0%; +0.3%] (no difference)
startup:petclinic:iast:Agent 16.40 s 16.94 s [-7.2%; +1.0%] (no difference)
startup:petclinic:profiling:Agent 16.40 s 16.84 s [-7.0%; +1.8%] (no difference)
startup:petclinic:sca:Agent 16.95 s 16.72 s [+0.6%; +2.2%] (maybe worse)
startup:petclinic:tracing:Agent 15.96 s 16.13 s [-2.0%; -0.1%] (maybe better)

Commit: c0280f76 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@PerfectSlayer PerfectSlayer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. The Javadoc was already explicit about context, glad we keep polishing the API.

@mcculls mcculls added this pull request to the merge queue Jul 10, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 10, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-10 12:30:40 UTC ℹ️ Start processing command /merge


2026-07-10 12:30:46 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-07-10 14:21:59 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 10, 2026

@amarziali amarziali left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. thanks for the heads up

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 674ebf5 into master Jul 10, 2026
979 of 986 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the mcculls/span-attachwithcontext branch July 10, 2026 14:21
@github-actions github-actions Bot added this to the 1.65.0 milestone Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants