Rename span.attachWithCurrent() to span.attachWithContext()#11907
Conversation
…r it over currentContext.with(span).attach()
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0280f764b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
PerfectSlayer
left a comment
There was a problem hiding this comment.
Looking good. The Javadoc was already explicit about context, glad we keep polishing the API.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
amarziali
left a comment
There was a problem hiding this comment.
nice. thanks for the heads up
674ebf5
into
master
What Does This Do
Rename
span.attachWithCurrent()tospan.attachWithContext()and prefer it overcurrentContext.with(span).attach()Motivation
attachWithContext()is more understandable to new developers and agentsContributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]