[reference] rxjava-3.0 async blind regeneration for #11927#11939
[reference] rxjava-3.0 async blind regeneration for #11927#11939jordan-wong wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Automated integration-authoring pass on rxjava-3.0, produced against the draft skill in #11927 (which was in-tree on the target checkout at generation time — using the skill-loading precedence fix from the 2026-07-13 HTTP cycle correction). Reference for #11927 reviewers to see concrete output the current skill draft produces. Not intended to be merged as-is. Base: master @ 05671ce (rebased from original bd134f3; the original branch inherited a stash-merge revert of #11852 during eval branch setup that dropped DD_TRACE_ROBOLECTRIC_ENABLED from metadata plus 172 unrelated files. This rebased version cherry-picks ONLY the rxjava-3.0 module output onto current master, preserving all unrelated upstream changes.) Cost: \$43.23, wall time ~3.5h, reviewer approved with 0 todos remaining. Diff scope: dd-java-agent/instrumentation/rxjava/rxjava-3.0/ only. Metadata: no change (all rxjava3 entries already present on master).
bd134f3 to
b46346b
Compare
|
Rebased 2026-07-14 — branch force-pushed onto current master to fix the shared Root cause (not a toolkit bug): the original eval branch inherited a stash-merge revert of #11852 during branch setup. The merge commit Fix: cherry-picked only the in-scope Result: 21 files changed (all under Original commit: |
mcculls
left a comment
There was a problem hiding this comment.
This is remarkably close, if we ignore some of the additional local knowledge / testing
[reference] rxjava-3.0 blind regeneration for #11927
Reference output from the toolkit's automated instrumentation-authoring
workflow, run against the draft skill in #11927. Not intended to be merged
as-is.
Research context
This PR is part of the async-category research cycle: verifying whether
the current skill draft in #11927 generalizes to Category B
(context-propagation) libraries after the HTTP-cycle skill updates. rxjava-3.0
was chosen because it has a mature existing implementation on master,
making regen output directly comparable.
Changes applied on top of eval output
Original eval branch inherited a stash-merge revert of #11852 during eval
branch setup, dropping DD_TRACE_ROBOLECTRIC_ENABLED from metadata plus 172
unrelated files. Root cause was a stale local checkout, not a toolkit or
skill issue. Rebased onto current master by cherry-picking only in-scope
paths under
dd-java-agent/instrumentation/rxjava/rxjava-3.0/.Original:
bd134f34bd→ rebased:b46346b45bWhere to focus review
The reference output should be compared against the master implementation
to surface how well the current skill draft preserves regen-critical
details. Known divergences:
super(...)alias dropped. Master hassuper("rxjava", "rxjava-3");eval produced
super("rxjava"). This silently breaks any customerusing
DD_TRACE_RXJAVA_3_ENABLEDas an opt-out toggle. This is thecanonical Rule First PR - Implements the Opentracing API #2 (regen-preservation) violation the skill should
prevent.
muzzle { fail { ... } }block missing. Master has an explicitfailblock asserting rxjava3 advice must not match against therxjava2 artifact (rxjava3 and rxjava2 use different Java namespaces
but the same Maven module name, so this is a real hazard). Eval
dropped the block entirely.
reactive-streamscompileOnly version regressed from1.0.3to1.0.0. Silent narrowing of the tested surface.Local CI-equivalent (
check+muzzle+latestDepTest) is fullygreen. The one remaining red check on CI (
muzzle: [3/8]) does notreproduce locally and appears to be a CI-side sharding flake.
Base: master @
05671ce3b0