Avoid Throwable::toString in ExceptionReplay - #12424
Conversation
Calling Throwable::toString is dangerous because it can be overriden. so instead of logging the toString of an exception we are using the class name
There was a problem hiding this comment.
More details
Both changed debug messages now use the exception class name. This keeps the log path from calling an overridden Throwable.toString method.
🤖 Datadog Autotest · Commit 3b1a995 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
This comment has been minimized.
This comment has been minimized.
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 5 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (339.05 µs) : 316, 362
. : milestone, 339,
basic (324.425 µs) : 319, 330
. : milestone, 324,
loop (8.092 ms) : 8029, 8154
. : milestone, 8092,
section candidate
noprobe (367.682 µs) : 318, 417
. : milestone, 368,
basic (337.955 µs) : 328, 348
. : milestone, 338,
loop (8.09 ms) : 8028, 8152
. : milestone, 8090,
|
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
What Does This Do
Calling Throwable::toString is dangerous because it can be overriden. so instead of logging the toString of an exception we are using the class name
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-6127