Skip to content

Use the mirrored Pub/Sub emulator image in CI - #13027

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
alexeyk/pubsub-emulator-mirror
Oct 24, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
alexeyk/pubsub-emulator-mirror

Conversation

@AlexeyKuznetsov-DD

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Use registry.ddbuild.io/images/mirror/google.com/cloudsdktool/google-cloud-cli:emulators for the Pub/Sub emulator in CI. Keep the existing GCR image for local runs, following the existing SQL Server image-selection pattern in the JDBC module introduced in #12633 — Track Testcontainers images as Gradle test inputs. Both select an internal mirror when CI is set and retain the upstream image for local runs.

Motivation

Resolving the upstream image manifest can fail with HTTP 429 when Google's Artifact Registry request quota is exceeded. The explicit gcr.io host bypasses the Docker Hub mirror prefix, so declare the mirrored image directly in CI.

Additional Notes

The mirror preserves the original upstream image and tag. Its live manifest digest was verified against the images repository lockfile: sha256:cced7aefc06898a91efcfc942e6ab98537b3ec2d15d66ec54cffa62ac6d7f19b.

Failure evidence:

Cannot resolve test container image 'gcr.io/google.com/cloudsdktool/google-cloud-cli:emulators'
429 Too Many Requests
GET https://gcr.io/v2/google.com/cloudsdktool/google-cloud-cli/manifests/emulators

Validation:

  • Verified the live mirror digest matches the lockfile.
  • Gradle configuration and module formatting succeeded.
  • Attempted ./gradlew :dd-java-agent:instrumentation:google-pubsub-1.116:latestDepTest :dd-java-agent:instrumentation:google-pubsub-1.116:latestDepForkedTest -PtestJvm=8; the run stopped during test initialization because no valid Docker environment was available. Runtime validation remains pending.

Contributor Checklist

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added type: bug fix Bug fix comp: testing Testing tag: no release notes Changes to exclude from release notes tag: ai generated Largely based on code generated by an AI or LLM labels Oct 23, 2026
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Oct 23, 2026
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD marked this pull request as ready for review October 23, 2026 18:33
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested a review from a team as a code owner October 23, 2026 18:33
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T18:35:46.066046Z 7df3cb2 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-23T18:37:49.417496Z 7df3cb2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-official

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 68.82% (+8.97%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7df3cb2 | Docs | Give us feedback!

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The mirrored image selection remains compatible with the existing image resolver and Pub/Sub container setup. Container startup remains unverified.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 7df3cb2

@dd-octo-sts

dd-octo-sts Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.96 s 13.91 s [-0.3%; +1.1%] (no difference)
startup:insecure-bank:tracing:Agent 12.92 s 12.95 s [-1.1%; +0.5%] (no difference)
startup:petclinic:appsec:Agent 17.10 s 16.99 s [-0.1%; +1.4%] (no difference)
startup:petclinic:iast:Agent 16.94 s 17.07 s [-1.4%; -0.1%] (maybe better)
startup:petclinic:profiling:Agent 16.84 s 16.81 s [-0.9%; +1.2%] (no difference)
startup:petclinic:sca:Agent 17.06 s 16.92 s [-0.1%; +1.8%] (no difference)
startup:petclinic:tracing:Agent 16.24 s 16.18 s [-0.5%; +1.3%] (no difference)

Commit: 7df3cb28 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@sarahchen6 sarahchen6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit d1b9478 into master Oct 24, 2026
621 of 624 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the alexeyk/pubsub-emulator-mirror branch October 24, 2026 00:10
@github-actions github-actions Bot added this to the 1.68.0 milestone Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants