Address code review feedback for build-and-summarize - #775
Draft
jbachorik wants to merge 1 commit into
Draft
Conversation
jbachorik
changed the title
Fixes an IndexError on stray log lines, test-count misattribution under parallel builds, and positional (rather than identity-based) pairing of failure headlines with failed tasks. Also removes an unverifiable comment about managed-settings model billing.
jbachorik
force-pushed
the
jb/fix-build-and-summarize
branch
from
September 1, 2026 15:46
dc33515 to
30357ff
Compare
Contributor
Scan-Build Report
Bug Summary
Reports
|
||||||||||||||||||||||||||||||||||||
Contributor
CI Test ResultsRun: #33527785367 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-09-01 16:03:20 UTC |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Fixes three bugs in the deterministic Gradle log parser inside
.claude/commands/build-and-summarize(added in an uncommitted local change prior to this PR, replacing a headless-claude-spawn approach with a self-contained Python parser):IndexErrorwhen a stray non-blank, non-*line appears between theFAILURE:banner and the* What went wrong:header, leavingheadlinesempty at index time.> Taskline was last seen," including non-test tasks that interleave with a test task's completion line.--continueand multiple failing tasks, headlines could land on the wrong task or go missing entirely.Also removes an unverifiable comment claiming managed settings pin a specific model and bill real money for log parsing — that claim isn't backed by anything in this file.
Motivation:
A code review of the uncommitted parser changes surfaced these correctness bugs before they shipped.
Additional Notes:
None.
How to test the change?:
Verified by hand-running the parser logic against a synthetic Gradle log that reproduces all three bugs (stray line before a headline, parallel task interleaving, multi-failure
--continueoutput) and confirming correct output with no crash.For Datadog employees: