v0.18.0#180
Merged
Merged
Conversation
String interning can grow WASM memory and detach existing DataViews while queueOp is assembling an operation. Refresh the change-buffer views after interning before writing the string id.
bengl
marked this pull request as ready for review
July 16, 2026 14:28
Overall package sizeSelf size: 30.17 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------|🤖 This report was automatically generated by heaviest-objects-in-the-universe |
bengl
force-pushed
the
bengl/v0.17.0-release-fix
branch
2 times, most recently
from
July 16, 2026 16:02
7a3c09c to
5c71852
Compare
bengl
force-pushed
the
bengl/v0.17.0-release-fix
branch
from
July 16, 2026 16:40
5c71852 to
42d3474
Compare
ekump
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@datadog/libdatadog@0.18.06356aee4c69b51f27e7e82e43b1797f60b74905aclientComputedStatsexports carrying bothdatadog-client-computed-stats: yesand Resource_dd.stats_computed=trueContext
dd-trace-jscomputes OTLP span metrics in JS. The native OTLP trace export path needs the client-computed stats marker from libdatadog so the Agent does not recompute the same stats. DataDog/libdatadog#2245 adds that marker when tracer metadata says client stats are computed.This PR also keeps the existing release-workflow fix from the previous branch state:
queueOp()must refresh WASM memory views aftergetStringId()because string interning can grow memory and detach the oldDataView.Verification
undefined !== 'yes'fordatadog-client-computed-statscargo build -p pipeline --target wasm32-unknown-unknown/Users/bryan.english/.nvm/versions/node/v26.5.0/bin/node scripts/build-wasm.js pipeline && /Users/bryan.english/.nvm/versions/node/v26.5.0/bin/node --test-force-exit test/pipeline.jspassed 52/52PATH="/Users/bryan.english/.nvm/versions/node/v26.5.0/bin:$PATH" yarn -s lint