fix(installer): accept a TestGen image that is already local - #92
Merged
Conversation
`tg install --image` refused any image built locally:
The Docker engine could not access TestGen's image.
The requirement ran `docker manifest inspect`, which asks the registry. That
answers "is this image published?", but what the install needs to know is "can
Docker obtain this image?" — and one already in the local engine needs no pull
at all. So a locally built image could never satisfy the check, which makes
testing a dev build of TestGen impossible.
Requirement gains an optional alt_cmd, tried when cmd fails, and the image
check now asks the local engine first and falls back to the registry. Local
first because it is instant, and because it lets an install proceed from cache
when the registry is unreachable.
This keeps the diagnostic the check was added for: a name that is neither local
nor pullable still fails with the same message. An opt-out flag would not have —
it disables the check wholesale, so a user hitting a genuine registry problem
and reaching for it would lose exactly the signal they need.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
aarthy-dk
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tg install --imagerefused any image built locally:The requirement ran
docker manifest inspect, which asks the registry. That answers "is this image published?", but what the install needs to know is "can Docker obtain this image?" — and one already in the local engine needs no pull at all. So a locally built image could never satisfy the check, which makes testing a dev build of TestGen impossible.Requirement gains an optional alt_cmd, tried when cmd fails, and the image check now asks the local engine first and falls back to the registry. Local first because it is instant, and because it lets an install proceed from cache when the registry is unreachable.
This keeps the diagnostic the check was added for: a name that is neither local nor pullable still fails with the same message. An opt-out flag would not have — it disables the check wholesale, so a user hitting a genuine registry problem and reaching for it would lose exactly the signal they need.