Skip to content

fix(installer): accept a TestGen image that is already local - #92

Merged
rboni-dk merged 1 commit into
mainfrom
fix/accept-local-testgen-image
Aug 26, 2026
Merged

fix(installer): accept a TestGen image that is already local#92
rboni-dk merged 1 commit into
mainfrom
fix/accept-local-testgen-image

Conversation

@rboni-dk

Copy link
Copy Markdown
Contributor

tg install --image refused any image built locally:

The Docker engine could not access TestGen's image.

The requirement ran docker manifest inspect, which asks the registry. That answers "is this image published?", but what the install needs to know is "can Docker obtain this image?" — and one already in the local engine needs no pull at all. So a locally built image could never satisfy the check, which makes testing a dev build of TestGen impossible.

Requirement gains an optional alt_cmd, tried when cmd fails, and the image check now asks the local engine first and falls back to the registry. Local first because it is instant, and because it lets an install proceed from cache when the registry is unreachable.

This keeps the diagnostic the check was added for: a name that is neither local nor pullable still fails with the same message. An opt-out flag would not have — it disables the check wholesale, so a user hitting a genuine registry problem and reaching for it would lose exactly the signal they need.

`tg install --image` refused any image built locally:

    The Docker engine could not access TestGen's image.

The requirement ran `docker manifest inspect`, which asks the registry. That
answers "is this image published?", but what the install needs to know is "can
Docker obtain this image?" — and one already in the local engine needs no pull
at all. So a locally built image could never satisfy the check, which makes
testing a dev build of TestGen impossible.

Requirement gains an optional alt_cmd, tried when cmd fails, and the image
check now asks the local engine first and falls back to the registry. Local
first because it is instant, and because it lets an install proceed from cache
when the registry is unreachable.

This keeps the diagnostic the check was added for: a name that is neither local
nor pullable still fails with the same message. An opt-out flag would not have —
it disables the check wholesale, so a user hitting a genuine registry problem
and reaching for it would lose exactly the signal they need.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@rboni-dk
rboni-dk merged commit 5e2eab0 into main Aug 26, 2026
3 checks passed
@rboni-dk
rboni-dk deleted the fix/accept-local-testgen-image branch August 26, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants