Ensure that semicolons in query and fragment strings are url-encoded.#9
Open
mbjones wants to merge 1 commit into
Open
Ensure that semicolons in query and fragment strings are url-encoded.#9mbjones wants to merge 1 commit into
mbjones wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates EncodingUtilities so semicolons (;) are no longer treated as unescaped characters in URL query and fragment encoding, ensuring they are percent-encoded (%3B) to avoid downstream 403 responses (per issue #8).
Changes:
- Removed
;from the fragment unescaped character set, which also affects the derived query unescaped set. - Updated the UTF-8 encoding test vector file to expect
%3Bfor semicolons in query and fragment cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/org/dataone/service/util/EncodingUtilities.java | Stops allowing ; as unescaped in fragments (and therefore query segments), so it will be encoded. |
| src/test/resources/org/dataone/service/encodingTestSet/testUnicodeStrings.utf8.txt | Updates expected encodings to reflect %3B for semicolons in query/fragment test cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed code so that semicolons
;are no longer in the reserved set and will be url-encoded in the query string and fragment string portions of a URL. Adjusted the tests to match.Closes issue #8