Skip to content

[COMPAT] Pin Triton to 3.8 #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mark14wu wants to merge 1 commit into from
Closed

[COMPAT] Pin Triton to 3.8 #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ concurrency:
jobs:
benchmark:
runs-on: ubuntu-latest
env:
# Keep `uv run` from re-syncing the environment to the lockfile, which
# would undo the Triton 3.8 pin installed with `uv pip install`.
UV_NO_SYNC: "1"

steps:
- name: Checkout PR branch
Expand Down Expand Up @@ -44,15 +48,15 @@ jobs:
run: |
cd main-branch
uv sync --extra test
uv pip install --pre -U triton
uv pip install "git+https://github.com/triton-lang/triton.git#subdirectory=python/triton_kernels"
uv pip install triton==3.8.0
uv pip install "git+https://github.com/triton-lang/triton.git@v3.8.0#subdirectory=python/triton_kernels"

- name: Install PR dependencies
run: |
cd pr-branch
uv sync --extra test
uv pip install --pre -U triton
uv pip install "git+https://github.com/triton-lang/triton.git#subdirectory=python/triton_kernels"
uv pip install triton==3.8.0
uv pip install "git+https://github.com/triton-lang/triton.git@v3.8.0#subdirectory=python/triton_kernels"

- name: Run interleaved A/B benchmarks
run: |
Expand Down
16 changes: 10 additions & 6 deletions .github/workflows/python-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ concurrency:
jobs:
build:
runs-on: ubuntu-latest
env:
# Keep `uv run` from re-syncing the environment to the lockfile, which
# would undo the Triton 3.8 pin installed with `uv pip install`.
UV_NO_SYNC: "1"

steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -48,11 +52,11 @@ jobs:
cd tilelens
uv sync --extra test

- name: Upgrade Triton to latest from main
- name: Install Triton 3.8
run: |
cd tilelens
uv pip install --pre -U triton
uv pip install "git+https://github.com/triton-lang/triton.git#subdirectory=python/triton_kernels"
uv pip install triton==3.8.0
uv pip install "git+https://github.com/triton-lang/triton.git@v3.8.0#subdirectory=python/triton_kernels"

- name: Run frontend tests
run: |
Expand All @@ -71,11 +75,11 @@ jobs:
cd tilelens
uv sync --extra test --extra nki

- name: Upgrade Triton to latest from main (NKI)
- name: Install Triton 3.8 (NKI)
run: |
cd tilelens
uv pip install --pre -U triton
uv pip install "git+https://github.com/triton-lang/triton.git#subdirectory=python/triton_kernels"
uv pip install triton==3.8.0
uv pip install "git+https://github.com/triton-lang/triton.git@v3.8.0#subdirectory=python/triton_kernels"

- name: Run full (Triton + NKI) pytest suite
run: |
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ classifiers = [
]
dependencies = [
"setuptools",
"triton>=3.8.0",
"triton>=3.8.0,<3.9",
"pyarrow",
"pre-commit",
"z3-solver==4.15.3.0",
Expand Down
Loading