Conversation
Build pure-Go Windows AMD64 and ARM64 archives, verify their PE machine types before and after packaging, and publish a windows_arm64 manifest entry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: afcbe814-11a6-45d4-988f-a4e6324b7de6
Detect the Windows OS architecture, including x64 PowerShell under ARM64 emulation, and cover installer selection, failures, checksums, and updater platform keys. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: afcbe814-11a6-45d4-988f-a4e6324b7de6
Run native ARM64 and AMD64 Windows build, smoke, installer, updater, and PE architecture checks, and document the PowerShell installation path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: afcbe814-11a6-45d4-988f-a4e6324b7de6
Assert the PATH status message in stable fragments so Windows PowerShell line wrapping on hosted runners does not create a false failure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: afcbe814-11a6-45d4-988f-a4e6324b7de6
Use the process PATH value as the authoritative assertion and avoid depending on Windows PowerShell host line wrapping. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: afcbe814-11a6-45d4-988f-a4e6324b7de6
Compare the process PATH before and after a second install instead of depending on host-wrapped status output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: afcbe814-11a6-45d4-988f-a4e6324b7de6
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Go |  |
Sep 16, 2026 6:17p.m. | Review ↗ |
| Secrets | |
Sep 16, 2026 6:17p.m. | Review ↗ |
| Code coverage |  |
Sep 16, 2026 6:48p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add native Windows ARM64 build, packaging, installer, updater-selection, and CI support while preserving the existing Windows AMD64 release path and CLI behavior.
Implementation
CGO_ENABLED=0for both Windows targets after confirming the complete Windows dependency graph has no CGO or native-object dependencies0x8664for AMD64 and0xAA64for ARM64)windows_amd64andwindows_arm64manifest entries and checksumsPROCESSOR_ARCHITEW6432so x64 PowerShell on Windows ARM selects the native ARM64 archivewindows-11-armand Windows AMD64 CI jobs with build, execution, PE, installer, and updater checksCompatibility
This is architecture enablement only. It does not change commands, flags, API endpoints, authentication, output schemas, exit-code behavior, configuration paths, or existing Linux/macOS support. Windows AMD64 and ARM64 were compared across 17 representative help, version, authentication, repository, analysis, completion, update, and invalid-command cases with identical normalized output and exit codes.
The Windows release path intentionally changes AMD64 from
CGO_ENABLED=1plus MinGW toCGO_ENABLED=0. Dependency inspection found noCgoFiles, C/C++ files, or.sysoobjects for either Windows target, and release-equivalent AMD64 and ARM64 builds passed.Validation
9ea935f419ad197b33dc233c8efd5e02cff1e96e:0x86640xAA64windows_arm64, verified SHA256, installed the executable, and launched it successfully.Security and workflow boundaries
contents: read; new checkout steps do not persist credentials.