Release drafter: exclude release-train merge PRs from release notes - #15780
Open
rossops wants to merge 1 commit into
Open
Release drafter: exclude release-train merge PRs from release notes#15780rossops wants to merge 1 commit into
rossops wants to merge 1 commit into
Conversation
The "Release: Merge release into master" and "Release: Merge back x.y.z" PRs are wrappers around the real changes, and the real changes already have their own entries. Excluding by the release-management label (which only the release workflows apply) removes the wrapper lines. It also stops those PRs from showing up under flagged sections like New Migration or settings_changes, which they picked up from the auto-labeler. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014PVsx4Seb8RU6nGt51E34T
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our drafted release notes currently include lines like
- Release: Merge release into master from: release/3.2.300and- Release: Merge back 3.2.201 into dev from: .... Those are just the wrappers around the real changes, which already get their own lines. This PR drops them.release-drafter can't filter by title text, but it doesn't have to. All three release workflows (
release-1-create-pr.yml,release-3-master-into-dev.yml) already tag their PRs withrelease-management, so this adds that label toexclude-labelsin.github/release-drafter.yml.Side benefit: those merge PRs also pick up labels like
New Migrationandsettings_changesfrom the path labeler, so today they show up under those flagged sections too. They won't anymore.Does it exclude anything else?
I checked. Every PR that has ever carried
release-management(80 in total) is a release-train merge. The only one whose title doesn't match the two patterns above is #14800, "Release 2.58.0: Merge Bugfix into Dev", which is the same kind of PR under an older title. Nothing else applies the label.Test results
Config-only change, no code to test. It can be checked by running the "Release Drafter (custom range)" workflow with
dry-run: truebefore the next real draft.Documentation
None needed.
🤖 Generated with Claude Code