ci(deploy-web): trigger on v* tags, drop the paths filter#215
Merged
Conversation
The v1.8.0 release fast-forwarded main with 67 changed web/ files, yet deploy-web never ran — the push 'paths: web/**' filter silently skipped it, so the live showcase kept serving the previous release until a manual workflow_dispatch. Drop the paths filter (main is only pushed at releases / hotfixes, so an unconditional deploy is cheap and correct) and add a 'v*' tag trigger as a second guaranteed path. Existing concurrency group de-dupes the two triggers a release fires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The v1.8.0 release fast-forwarded
mainwith 67 changedweb/files, butdeploy-webnever ran — thepushpaths: web/**filter silently skipped it, so the live showcase kept serving the v1.7.1 site (stale thumbnails) until a manualworkflow_dispatch.What
pathsfilter.mainis only pushed at releases / hotfixes, so deploying unconditionally is cheap (~30s) and always correct — and it removes the exact thing that swallowed the v1.8.0 deploy.tags: ["v*"]trigger as a second, guaranteed deploy path for releases. (Combiningtagswithpathsis unreliable — tag pushes have no clean before/after to path-diff — which is the other reasonpathshad to go.)concurrency: { group: pages, cancel-in-progress: true }de-dupes the two triggers a release fires (main ff + tag).Tests
on.push.branches=[main],on.push.tags=[v*], singledeployjob intact).