Map: OSM provider - Add marker tooltips - #35164
Open
AlisherAmonulloev wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation is cohesive and extensively covers interaction, accessibility, positioning, and cleanup behavior.
Pull request overview
Adds accessible marker tooltips to the OpenStreetMap provider using DevExtreme Popovers.
Changes:
- Implements tooltip rendering, positioning, keyboard handling, focus restoration, and cleanup.
- Adds tooltip styling and Storybook controls.
- Adds comprehensive QUnit coverage and updates the OpenLayers mock.
File summaries
| File | Description |
|---|---|
packages/devextreme/testing/tests/DevExpress.ui.widgets/mapParts/osmTests.js |
Covers tooltip behavior, accessibility, lifecycle, and positioning. |
packages/devextreme/testing/helpers/forMap/openLayersMock.js |
Attaches mock overlay containers to the map target. |
packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.ts |
Passes tooltip options and manages cleanup focus behavior. |
packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.openlayers.ts |
Integrates tooltips with OpenLayers markers. |
packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.openlayers.tooltip.ts |
Implements the marker tooltip component. |
packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.openlayers.popover.ts |
Adds specialized Popover positioning behavior. |
packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.engine.ts |
Extends internal marker contracts for tooltips and cleanup. |
packages/devextreme-scss/scss/widgets/base/_map.scss |
Styles marker Popovers and close controls. |
apps/react-storybook/stories/map/OSMMap.stories.tsx |
Demonstrates configurable OSM marker tooltips. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AlisherAmonulloev
marked this pull request as ready for review
September 11, 2026 10:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.