CardView: fix editing form fill when customizeItem set - #35166
Open
anna-shakhova wants to merge 1 commit into
Open
CardView: fix editing form fill when customizeItem set#35166anna-shakhova wants to merge 1 commit into
customizeItem set#35166anna-shakhova wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Runtime changes to editing.form.customizeItem are not propagated to the underlying dxForm.
Pull request overview
Updates CardView editing-form customization when editing.form.customizeItem is configured.
Changes:
- Composes built-in and user
customizeItemhandlers. - Preserves internal customization precedence.
- Adds integration coverage for form population and customization.
File summaries
| File | Summary |
|---|---|
packages/devextreme/js/__internal/grids/new/grid_core/editing/popup/view.ts |
Combines customization handlers. Moderate finding (1 vote): runtime callback changes are not propagated to the underlying dxForm. |
packages/devextreme/js/__internal/grids/new/grid_core/editing/popup/view.integration.test.ts |
Adds integration coverage for editing-form customization. |
packages/devextreme/js/__internal/grids/new/grid_core/editing/popup/component.tsx |
Ensures internal customization is passed to the form. |
Review details
Suppressed comments (1)
packages/devextreme/js/__internal/grids/new/grid_core/editing/popup/view.ts:155
- Changing
editing.form.customizeItemafter the popup has been rendered no longer causes the underlyingdxFormto receive a newcustomizeItemoption.customizeItemsis a stable function and the user callback is only read viapeek(), whileInfernoWrapperupdates widget options by comparing the final callback identity; consequently Form'scustomizeItemoption-change path, which rebuilds the items, is never triggered. Make the wrapper depend on the user callback and pass its current value (or otherwise propagate a callback-identity change) so runtime option updates reapply customization.
private readonly customizeItems = (item: dxForm.Item): void => {
this.customizeItemCore(item);
this.options.oneWay('editing.form.customizeItem').peek()?.(item);
};
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.