Feat/systemjs remove qunit runner - #35176
Open
vorobey wants to merge 13 commits into
Open
Conversation
…systemjs-remove-from-qunit-testinng
…systemjs-remove-from-qunit-testinng
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andrey Vorobev <738482+vorobey@users.noreply.github.com>
Signed-off-by: Andrey Vorobev <738482+vorobey@users.noreply.github.com> Co-authored-by: Dmitry Lavrinovich <52966626+dmlvr@users.noreply.github.com> Co-authored-by: Andrei Kharitonov <pharret31@users.noreply.github.com> Co-authored-by: Maksim Zakharov <251575087+bit-byte0@users.noreply.github.com> Co-authored-by: EugeniyKiyashko <EugeniyKiyashko@users.noreply.github.com> Co-authored-by: Alyar <Alyar666@users.noreply.github.com> Co-authored-by: Eldar Iusupzhanov <84278206+Tucchhaa@users.noreply.github.com> Co-authored-by: Eldar Iusupzhanov <eldar.iusupzhanov@users.noreply.github.com> Co-authored-by: Anna Shakhova <68295572+anna-shakhova@users.noreply.github.com> Co-authored-by: Alex Lavrov <36633600+alexslavr@users.noreply.github.com> Co-authored-by: Arman Jivanyan <arman.jivanyan@devexpress.com> Co-authored-by: Aleksei Semikozov <2846685+aleksei-semikozov@users.noreply.github.com> Co-authored-by: Aleksey Semikozov <aleksei.semikozov@devexpress.com> Co-authored-by: ilya.kharchenko <14272298+IlyaKhD@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Raushen <andrey.dolzhikov@devexpress.com> Co-authored-by: Tom <22076961+artem-kurchenko@users.noreply.github.com>
Signed-off-by: Andrey Vorobev <738482+vorobey@users.noreply.github.com> Signed-off-by: Dmitry Lavrinovich <52966626+dmlvr@users.noreply.github.com> Co-authored-by: Dmitry Lavrinovich <52966626+dmlvr@users.noreply.github.com> Co-authored-by: Andrei Kharitonov <pharret31@users.noreply.github.com> Co-authored-by: Maksim Zakharov <251575087+bit-byte0@users.noreply.github.com> Co-authored-by: EugeniyKiyashko <EugeniyKiyashko@users.noreply.github.com> Co-authored-by: Alyar <Alyar666@users.noreply.github.com> Co-authored-by: Eldar Iusupzhanov <84278206+Tucchhaa@users.noreply.github.com> Co-authored-by: Eldar Iusupzhanov <eldar.iusupzhanov@users.noreply.github.com> Co-authored-by: Anna Shakhova <68295572+anna-shakhova@users.noreply.github.com> Co-authored-by: Alex Lavrov <36633600+alexslavr@users.noreply.github.com> Co-authored-by: Arman Jivanyan <arman.jivanyan@devexpress.com> Co-authored-by: Aleksei Semikozov <2846685+aleksei-semikozov@users.noreply.github.com> Co-authored-by: Aleksey Semikozov <aleksei.semikozov@devexpress.com> Co-authored-by: ilya.kharchenko <14272298+IlyaKhD@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Raushen <andrey.dolzhikov@devexpress.com> Co-authored-by: Tom <22076961+artem-kurchenko@users.noreply.github.com>
…systemjs-remove-from-qunit-testinng
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The unresolved critical no-jQuery runner failure and moderate bundled-suite coverage issue must be addressed.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
packages/devextreme/testing/tests/DevExpress.jquery/bundled.tests.js:3
- This suite is named
bundledbut the new import bypasses the bundle and loads the sourceui/buttonmodule directly. As a result, these assertions can pass even whendx.all.jsis broken or fails to register the jQuery plugin; loadbundles/dx.all.jshere and instantiate the button from the bundle's registeredDevExpress.uiconstructor instead.
- Files reviewed: 300/368 changed files
- Comments generated: 1
- Review effort level: Lite
Comment on lines
97
to
99
| if (isNoJQueryTest) { | ||
| return `${testingBasePath}helpers/noJQuery.js`; | ||
| return `${TESTING_BASE}helpers/noJQuery.js`; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.