Grids - FilterController: Move updateFilter into FilterController - #35178
Open
bit-byte0 wants to merge 1 commit into
Open
Grids - FilterController: Move updateFilter into FilterController#35178bit-byte0 wants to merge 1 commit into
updateFilter into FilterController#35178bit-byte0 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified that would block approval.
Pull request overview
Moves filter-selector normalization from ColumnsController into FilterController, keeping combined-filter construction centralized.
Changes:
- Adds
normalizeFilterSelectorsand recursive normalization logic. - Updates
DataControllerto use the new method. - Removes the old method and updates related types/tests.
File summaries
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/filter/filter_controller.ts | Updated as part of this pull request. |
| packages/devextreme/js/__internal/grids/grid_core/filter/tests/filter_controller.normalize_filter_selectors.test.ts | Updated as part of this pull request. |
| packages/devextreme/js/__internal/grids/grid_core/data_controller/data_controller.ts | Updated as part of this pull request. |
| packages/devextreme/js/__internal/grids/grid_core/columns_controller/types.ts | Updated as part of this pull request. |
| packages/devextreme/js/__internal/grids/grid_core/columns_controller/m_columns_controller.ts | Updated as part of this pull request. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the filter-selector normalization (turning column data fields into their selectors and serializing filter values) out of
ColumnsControllerintoFilterControllerHow
The logic now lives in
FilterControllerasnormalizeFilterSelectors, called by the data controller while it builds the combined filter; behavior is unchanged