perf(dgw): avoid cloning decoded frames - #1955
Open
Benoît Cortier (CBenoit) wants to merge 1 commit into
Open
Conversation
Re-encoding cloned each decoded video frame after extracting it.\nMove the sole frame out of the collection to avoid that allocation\nand copy. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
Implementation notes:
Validation:
Note Human-tuned, LLM-assisted content. |
Contributor
There was a problem hiding this comment.
Pull request overview
Optimizes video frame extraction by moving the sole decoded frame instead of cloning it.
Changes:
- Replace frame cloning with
Vec::pop. - Add a SimpleBlock extraction test.
- No material issues identified.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-encoding cloned each decoded video frame after extracting it. Move the sole frame out of the collection to avoid that allocation and copy.