Repository navigation
Call setter only when technique has changed - #232
Merged
Merged
Conversation
If the technique toggle is clicked such that the technique isn't changed (ie, the technique toggle button corresponding to the already selected technique is clicked), `null` is the new value from the change handler, which causes the technique to be set to `null`, and crashes the app when the technique value is attempted to be turned to a string with all lower case characters (the `toLowerCase()` is present on strings but not on `null`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the technique toggle is clicked such that the technique isn't changed (ie, the technique toggle button corresponding to the already selected technique is clicked),
nullis the new value from the change handler, which causes the technique to be set tonull, and crashes the app when the technique value is attempted to be turned to a string with all lower case characters (thetoLowerCase()is present on strings but not onnull).