Skip to content

LIMS-2228: Move hmap and caman out of vendors folder - #1088

Open
ndg63276 wants to merge 1 commit into
masterfrom
improvement/LIMS-2228/move-js-libs-into-package.json
Open

LIMS-2228: Move hmap and caman out of vendors folder#1088
ndg63276 wants to merge 1 commit into
masterfrom
improvement/LIMS-2228/move-js-libs-into-package.json

Conversation

@ndg63276

Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-2228

Summary:

There are a few JS libraries manually inserted into the vendors folder, they should be moved to package.json if possible.

Changes:

  • Remove heatmap file, remove alias, add heatmap.js to package.json, update imports
  • Remove caman file, remove alias, add caman-dist-only to package.json, update imports and manually declare Caman
  • Don't install http or fs as part of caman, update imports-loader so caman knows we are running in a browser
  • Remove backbone.syphon file, update imports (backbone.syphon was already in package.json)
  • Remove unused luxon import, luxon was removed in LIMS-2044: Remove luxon #1022

To test:

  • heatmap.js:
    • Go to a container with grid scans (eg /containers/cid/379691, well B8d2), check the results heatmap is still displayed
    • Go to a recent grid scan (eg /dc/visit/cm44138-3/id/24524776), check the results heatmap is still displayed
  • caman:
    • Check the diffraction viewer still works on the grid scan
    • Go to a rotation data collection (eg /dc/visit/cm44138-3/id/24524800), check the diffraction image viewer still works
  • backbone.syphon
    • Go to a SAXS proposal, eg cm44173, check you can still make a shipment and a puck within it (you may need to make a protein first)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant