I06 magnet scaler cards and detectors - #2132
Merged
Merged
Conversation
…/dodal into add_i06_magnets
…/dodal into add_i06_magnets
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2132 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 367 367
Lines 14545 14584 +39
=======================================
+ Hits 14429 14468 +39
Misses 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 tasks
oliwenmandiamond
marked this pull request as ready for review
August 18, 2026 10:02
Relm-Arrowny
requested changes
Aug 18, 2026
Co-authored-by: Raymond Fan <raymond.fan@diamond.ac.uk>
Relm-Arrowny
approved these changes
Aug 18, 2026
Comment on lines
+68
to
+69
| timeout = await self.integration_time.get_value() + DEFAULT_TIMEOUT | ||
| await wait_for_value(self.start_count, False, timeout) |
Contributor
There was a problem hiding this comment.
Nit: default_timeout probably is overkill at 10,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DiamondLightSource/sm-bluesky#339
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}