Skip to content

Add visr devices - #2168

Draft
EmsArnold wants to merge 12 commits into
mainfrom
add_visr_devices
Draft

Add visr devices#2168
EmsArnold wants to merge 12 commits into
mainfrom
add_visr_devices

Conversation

@EmsArnold

@EmsArnold EmsArnold commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Adds devices to ViSR (b01-1). PV names changed slightly with updated IOCs, theta tomography stage added. Instructions to ssh to b01-1 network removed as CA PVs now available as read-only outside beamline network (equivalent to other instruments).

Instructions to reviewer on how to test:

  1. Confirm all devices connect with dodal connect b01_1

Checks for reviewer

  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.18%. Comparing base (b4b38f1) to head (ff41ec0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2168   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         360      360           
  Lines       14296    14308   +12     
=======================================
+ Hits        14180    14192   +12     
  Misses        116      116           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EmsArnold
EmsArnold marked this pull request as ready for review August 11, 2026 07:33
@EmsArnold
EmsArnold requested a review from a team as a code owner August 11, 2026 07:33
@EmsArnold
EmsArnold requested a review from tomkane-dls August 11, 2026 07:33

@tomkane-dls tomkane-dls left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@EmsArnold
EmsArnold marked this pull request as draft August 12, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants