Skip to content

add per_step timeout to i06 vector magnet - #2170

Open
Relm-Arrowny wants to merge 2 commits into
mainfrom
2166-add-dynamic-step-timeout-calculation-for-vector-magnet-movements-i06
Open

add per_step timeout to i06 vector magnet#2170
Relm-Arrowny wants to merge 2 commits into
mainfrom
2166-add-dynamic-step-timeout-calculation-for-vector-magnet-movements-i06

Conversation

@Relm-Arrowny

@Relm-Arrowny Relm-Arrowny commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Fixes #2166

Changes:

  • Added calculate_timeout_per_step in SuperConductingMagnetController
  • Modified SuperConductingMagnetControllerto make use of calculate_timeout_per_step
  • Added get_ramp_rate to ThreeMagnetAxisPowerSupply

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Relm-Arrowny Relm-Arrowny linked an issue Aug 11, 2026 that may be closed by this pull request
4 tasks
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.18%. Comparing base (b4b38f1) to head (92baa83).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2170   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         360      360           
  Lines       14296    14306   +10     
=======================================
+ Hits        14180    14190   +10     
  Misses        116      116           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Relm-Arrowny
Relm-Arrowny marked this pull request as ready for review August 11, 2026 13:32
@Relm-Arrowny
Relm-Arrowny requested a review from a team as a code owner August 11, 2026 13:32
@Relm-Arrowny Relm-Arrowny changed the title add per_step timeout add per_step timeout to i06 vector magnet Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dynamic step timeout calculation for vector magnet movements (i06)

1 participant