Skip to content

Ensure public address always present - #105

Merged
tpoliaw merged 4 commits into
mainfrom
public_address
Aug 17, 2026
Merged

tpoliaw merged 4 commits into
mainfrom
public_address

Conversation

@tpoliaw

@tpoliaw tpoliaw commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

The address where the glazed service is accessible may be different from
the address to which it is bound. Making both fields available in the
configuration means either can be overridden but both will have sensible
defaults.

The default values are also changed

  • bind_address now defaults to 127.0.0.1 instead of 0.0.0.0 so it is not
    publicly accessible
  • public_address now defaults to localhost:3000 instead of defaulting to
    the same as the bind_address

The trailing slash at the end of the public address is no longer
significant and will be normalised before appending the graphql
component.

@tpoliaw
tpoliaw requested a review from a team as a code owner January 19, 2026 18:04
@codecov

codecov Bot commented Jan 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 56.00000% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.26%. Comparing base (9f67b1c) to head (df16d87).

Files with missing lines Patch % Lines
src/main.rs 25.00% 12 Missing ⚠️
src/config.rs 80.00% 6 Missing ⚠️
src/handlers.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   51.86%   54.26%   +2.39%     
==========================================
  Files          14       14              
  Lines         750      774      +24     
==========================================
+ Hits          389      420      +31     
+ Misses        361      354       -7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoliaw
tpoliaw force-pushed the public_address branch 2 times, most recently from 0f107e1 to ae74550 Compare August 7, 2026 09:19
@tpoliaw
tpoliaw merged commit d73b954 into main Aug 17, 2026
7 checks passed
@tpoliaw
tpoliaw deleted the public_address branch August 17, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants