Repository navigation
Support subscription to tiled via websocket - #106
Conversation
Read initial log level from config file if present. Once the server is
running the level can be changed via a POST request to /loglevel/{level}
where level is one of info, debug or trace.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 51.47% 51.86% +0.38%
==========================================
Files 13 14 +1
Lines 643 750 +107
==========================================
+ Hits 331 389 +58
- Misses 312 361 +49 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Possibly related to this, I'm not able to run any subscriptions. Is there a way to get it working with the current state or does the auth stuff need fixing first? |
|
The way I'm testing it is by chaning these lines in the tiled server code to just return "secret" I tried to get the headers today but could'nt find a way |
691e822 to
4bb20a3
Compare
tpoliaw
left a comment
There was a problem hiding this comment.
The public_address problem and the error reporting are the main changes needed - most of the other comments aren't critical
|
@tpoliaw I have fixed the public address issue and the errors are also reported now. Think to note : tiled has a new way of doing auth for websocket To test if errors are coming try adding the apikey header with a wrong value For unit tests:- |
tpoliaw
left a comment
There was a problem hiding this comment.
The graphiql editor is also failing to get the schema with a CORS error - no idea why
tpoliaw
left a comment
There was a problem hiding this comment.
Mostly minor stuff now. It's looking good
tpoliaw
left a comment
There was a problem hiding this comment.
I think this can go in now. Any changes that are needed when it starts being used can be opened as new PRs/issues
These are the limitation of the tiled server ws
Currently I can get updates on the root node of creation of new node
and patch updates + creation updates for a particular node
To test the subscription to tiled websocket
docker run -d --rm --name tiled-test-redis -p 6379:6379 docker.io/redis:7-alpinetiled serve catalog --temp --api-key secret --cache redis://localhost:6379Todo:
I was not able to pass the API key in the header(Done)testsDone with help from gemini