Fix slot number determination logic for the FIB workflow by tieneupin · Pull Request #842 · DiamondLightSource/python-murfey

Moved slot number determination logic into a separate utility function that accepts a variable 'rotation_offset' parameter

tieneupin

committed

d406737

Updated FIB context and 'register_milling_progress' workflow so that the rotation offset parameter is extracted from the MachineConfig as a dict from the 'calibrations' field

tieneupin

committed

31e4681

Updated FIBContext tests

tieneupin

committed

e0bd468

Pass values directly into 'get_slot_number' function instead of Pydantic model

tieneupin

committed

f06a942

Forgot to remove commented out block

tieneupin

committed

5635666

Pass stage position values to 'get_slot_number' directly in the FIBContext

tieneupin

committed

9310e0f

Updated 'register_atlas' workflow so that rotation offset information is fed in from the MachineConfig

tieneupin

committed

7ef8504

Updated tests

tieneupin

committed

1e0fc41

Missed fixing an instance of 'get_slot_number'

tieneupin

committed

aeaffd6

Merged recent changes from 'main' branch

tieneupin

committed

73ef54e

Fixed broken test

tieneupin

committed

8791a54

Added comments about function purpose and angle units

tieneupin

committed

ab0f5a1

Added comments about angle units

tieneupin

committed

6829465

Navigation Menu

Repository navigation

Fix slot number determination logic for the FIB workflow - #842

Fix slot number determination logic for the FIB workflow#842
tieneupin merged 15 commits into
mainfrom
slot-number-fix

Commits on Jul 16, 2026

Updated slot number determination logic in the 'StagePositionValues' Pydantic model

Updated tests to reflect new stage position logic

Commits on Jul 24, 2026

Moved slot number determination logic into a separate utility function that accepts a variable 'rotation_offset' parameter

Updated FIB context and 'register_milling_progress' workflow so that the rotation offset parameter is extracted from the MachineConfig as a dict from the 'calibrations' field

Updated FIBContext tests

Pass values directly into 'get_slot_number' function instead of Pydantic model

Forgot to remove commented out block

Pass stage position values to 'get_slot_number' directly in the FIBContext

Updated 'register_atlas' workflow so that rotation offset information is fed in from the MachineConfig

Updated tests

Missed fixing an instance of 'get_slot_number'

Merged recent changes from 'main' branch

Fixed broken test

Added comments about function purpose and angle units

Added comments about angle units