Repository navigation
Record 'last active' time for SPA particle picking and tomo motion correction jobs - #913
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
==========================================
- Coverage 55.50% 55.35% -0.15%
==========================================
Files 103 103
Lines 11588 11632 +44
Branches 1546 1546
==========================================
+ Hits 6432 6439 +7
- Misses 4807 4844 +37
Partials 349 349 🚀 New features to boost your workflow:
|
…ked_particles' workflow
tieneupin
marked this pull request as ready for review
October 9, 2026 15:56
stephen-riggs
approved these changes
Oct 12, 2026
stephen-riggs
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. The session ids will already be ints in endpoints coming from the client, but just inting everything does make the most sense
Contributor
Author
|
Thanks for reviewing, Stephen. PR ended up becoming more convoluted than expected. In the longer run, as we break the items in |
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent incident involving a user cleaning up a session that was still undergoing processing has highlighted the need for more safeguards to be implemented.
One starting safeguard would be recording when the processing was last registered on the session. When
motion_correctedorpicked_particlesmessages are sent back to the Murfey feedback queue, The timestamp of when that job was received will be stored in the MurfeySessiontable. This information can then be used by the frontend to filter out sessions with ongoing processing if a cleanup/deletion request is sent.This change also revealed some side effects from the recent SQLAlchemy change (see #910 ). Database queries now require the query parameter types to match. For instance, when running an
execcommand whereDataCollectionGroup.id == message["dcg_id"], the contents ofmessage["dcg_id"]must now be an int).As part of this PR, all instances of
message["session_id"]andmessage["program_id"]inmurfey.serverandmurfey.workflowswere forcibly converted to ints.