Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
staging-devin-ai-integration
Bot
changed the base branch from
main
to
devin/1791068178-box-shadow-api
October 3, 2026 22:59
Upgrade to the linebender/vello#1718 branch (via [patch.crates-io]) and draw blurred box shadows with fill_blurred_rounded_rect_in / draw_blurred_rounded_rect_in and invert, so inset shadows no longer need compositing layers.
staging-devin-ai-integration
Bot
force-pushed
the
devin/1791048554-box-shadow-shape-inset
branch
from
October 3, 2026 23:17
7d34ab5 to
eaf7913
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #117, and based on it. It upgrades to linebender/vello#1718, then switches the Vello backends to its
*_blurred_rounded_rect_inmethods withinvert. As a result, blurred inset shadows no longer need compositing layers. Thedraw_box_shadowAPI from #117 is unchanged.Unblurred shadows and Skia are unchanged from #117.
Do not merge yet:
Cargo.tomlhas a[patch.crates-io]that points vello* and glifo at the linebender/vello#1718 branch. It needs removing once that's released.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/45dbc6c083354777aaa43442ce8ef8ab
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/45dbc6c083354777aaa43442ce8ef8ab?variant=devin-insiders
Requested by: @nicoburns