Mark PR WPT results as pending while a new run is computing - #702
Open
nicoburns wants to merge 1 commit into
Open
Mark PR WPT results as pending while a new run is computing#702nicoburns wants to merge 1 commit into
nicoburns wants to merge 1 commit into
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After pushing to a PR there's a window where the WPT results in the description are stale with no indication of it. This adds a pending notice at the start of each WPT run, keeping the old results visible.
The "Post WPT results" workflow now also triggers on
workflow_run: in_progress, with a newmark-pendingjob that runswpt_diff_to_pr.py --pending. (The pending update lives in this trustedworkflow_runworkflow, not the WPT job itself, because the WPT job runs with the read-only fork-PR token.)--pendinginserts a> [!NOTE]alert under the## WPT resultsheading, delimited by new<!-- wpt-pending-start/end -->markers nested inside the existing results markers:Because the notice is nested inside the results section, posting the final results (which replaces everything between the results markers) removes it automatically with no extra logic. If there are no previous results yet,
--pendingcreates the results section with a "results will be posted here" notice instead.A
mark-failedjob (oncompletedwithconclusion == 'failure') runs--failed, which replaces the pending notice with a> [!WARNING]failure notice so a failed run doesn't leave a permanent "being computed" message. Cancelled runs are deliberately not handled: cancellation normally comes fromcancel-in-progresswhen a new run starts, and clearing the notice there would race with the new run'smark-pending.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/549f86c7156a4b59aa01c59657fd74b2
Requested by: @nicoburns