Skip to content

FEE-840 Add schema import for Obsidian#1164

Open
trangdoan982 wants to merge 3 commits into
fee-840-export-schemafrom
fee-840-import-schema
Open

FEE-840 Add schema import for Obsidian#1164
trangdoan982 wants to merge 3 commits into
fee-840-export-schemafrom
fee-840-import-schema

Conversation

@trangdoan982

@trangdoan982 trangdoan982 commented Jun 26, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds an Import discourse graph schema command and settings entry point
  • Users pick a dg-schema-*.json file via the Electron native open dialog
  • Preview step computes a match plan (id match, then name/label fallback) and shows per-category stats (new vs existing) for the full file before any changes are made
  • On apply, new items are created as provisional; existing matches are skipped (no destructive merges)
  • Relation triples, node types, and relation types in the selection panel enforce the same dependency constraints as export

Test plan

  • pnpm --filter @discourse-graphs/obsidian check-types
  • Open Import schema modal from command palette
  • Open Import schema modal from Settings
  • Pick an exported dg-schema-*.json file; verify preview stats are correct
  • Verify id-matched items show as existing; name/label-matched items show as existing
  • Import selected items; confirm new node types, relation types, triples created as provisional
  • Re-import the same file; confirm no duplicates created

Stack

Stacked on #1163 (export PR). Base branch: fee-840-export-schema.

Made with Cursor


Open in Devin Review

Adds an Import discourse graph schema command and settings entry point. Users
pick a dg-schema-*.json file via the Electron open dialog; the preview step
builds a match plan (id → name/label fallback) and shows per-category stats.
On apply, new items are created as provisional and existing matches are skipped.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
discourse-graph Skipped Skipped Jun 29, 2026 2:29pm

Request Review

@linear-code

linear-code Bot commented Jun 26, 2026

Copy link
Copy Markdown

FEE-840

@graphite-app

graphite-app Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

PR size/scope check

This PR is over our review-size guideline.

  • Recommended: ~200 lines changed
  • Acceptable limit: up to 400 lines when well-scoped/self-contained
  • Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

  • What single problem this PR solves
  • Why the files/changes are coupled

@supabase

supabase Bot commented Jun 26, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread apps/obsidian/src/utils/specImport.ts
… already exists locally

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant