Skip to content

ENG-1929 Multiple additional relations bug#1176

Merged
mdroidian merged 2 commits into
mainfrom
eng1929-multiple-additional-relations
Jun 28, 2026
Merged

ENG-1929 Multiple additional relations bug#1176
mdroidian merged 2 commits into
mainfrom
eng1929-multiple-additional-relations

Conversation

@mdroidian

@mdroidian mdroidian commented Jun 28, 2026

Copy link
Copy Markdown
Member

https://www.loom.com/share/97c8d205bb8f4301ae06150144429d2b

Summary

  • Add a scoped suppression helper for auto-generated canvas relations
  • Skip relation creation while loading local canvases into the cloud store so migrated canvases stay unchanged
  • Cover suppression scope, nesting, and error recovery with unit tests

Testing

  • Unit tests added for suppression behavior, including nested callbacks and thrown errors

Open in Devin Review

@vercel

vercel Bot commented Jun 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
discourse-graph Skipped Skipped Jun 28, 2026 11:17pm

Request Review

@linear-code

linear-code Bot commented Jun 28, 2026

Copy link
Copy Markdown

ENG-1929

@supabase

supabase Bot commented Jun 28, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@mdroidian

Copy link
Copy Markdown
Member Author

@codex review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 9ac9650be7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mdroidian

Copy link
Copy Markdown
Member Author

@codex review

- Introduced `shouldCreateAutoCanvasRelations` function to determine if auto canvas relations should be created based on the source (user or remote).
- Updated the `Tldraw` component to utilize the new function, ensuring that auto canvas relations are only created for user-generated records when suppression is not active.
- Added unit tests to validate the behavior of the new function under different scenarios, including suppression states.
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: bdcd3e2ec2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mdroidian mdroidian merged commit d35951f into main Jun 28, 2026
10 checks passed
@mdroidian mdroidian deleted the eng1929-multiple-additional-relations branch June 28, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant