Conversation
If the response of rpc call is separate into serval fragments, will trying to hold them and merge into ONE buffer. This bug will happen when using this client to download large files.
Author
|
@twincitiesguy Hello, could you review my code ? I've tested in my project, and it works right. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the response of rpc call is separate into serval fragments, will trying to hold them and merge into ONE buffer.
This bug will happen when using this client to download large files.
Here is some log when I download a file with 160MB. It has a large rpc call, and separated into 9 fragments. In old version,
_recordLength is adds up but buffer didn't hold bytes all