Repository navigation
ci: set least-privilege GITHUB_TOKEN permissions (SEC-843) - #398
Draft
Matt Sutkus (msuitcase) wants to merge 1 commit into
Draft
Matt Sutkus (msuitcase) wants to merge 1 commit into
Matt Sutkus (msuitcase) wants to merge 1 commit into
Conversation
Default the workflow token to read-only. Only the docs job writes to the repo (gh-pages deploy), so it alone gets contents: write. Refs SEC-843
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
permissions: contents: read.docsjob:contents: write, which the gh-pages deploy needs.Why
The workflow had no
permissions:block, so every job got the repo's default token scope. With this change, a job that only builds and tests gets a read-only token.Testing note
docsonly runs onmaster, so this PR's CI doesn't exercise it. Check the firstdocsrun after merge.Stack
persist-credentials: falsePart of SEC-842.