pyln-testing: Fix flakyness on test_no_delay assertion introducing a statistical margin#9231
Open
ScuttoZ wants to merge 3 commits into
Open
pyln-testing: Fix flakyness on test_no_delay assertion introducing a statistical margin#9231ScuttoZ wants to merge 3 commits into
ScuttoZ wants to merge 3 commits into
Conversation
… of fixed amount to reduce flakiness
ScuttoZ
force-pushed
the
fix-flake-test_no_delay-9218
branch
from
be1f8c3 to
185481a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a statistical margin instead of relative time when calculating nagle-disabled time-saves to reduce flakiness in test_connection.py::test_no_delay.
Defaults are now 100 round trips with and without nagle and the assertions use a margin of 3 times the standard error (subtracted for Linux since the time-save is expected to be more significant).
Changelog-None