Skip to content

reckless: rust rewrite#9239

Draft
daywalker90 wants to merge 1 commit into
ElementsProject:masterfrom
daywalker90:reckless-rs
Draft

reckless: rust rewrite#9239
daywalker90 wants to merge 1 commit into
ElementsProject:masterfrom
daywalker90:reckless-rs

Conversation

@daywalker90

Copy link
Copy Markdown
Collaborator

Not ready for code review yet, we have not decided on some important aspects. Right now it is a drop-in replacement of the python reckless version.

Should
Fixes: #8439
Fixes: #8761
Fixes: #8775
Fixes: #8776
Fixes: #8794
and should supercede #8630

Key differences:

  • it is now a plugin only, the only use case to have a standalone binary, that i could come up with, is a broken plugin install where CLN won't start, but if you can call a binary you can uncomment a line in a config, right?
  • as a consequence, alot of options are no longer necessary and reckless-dir is a proper plugin option now
  • except for the help we always output json, so no more --json option
  • the rewrite does not adhere to the reckless schema in all places, e.g. listavailable, an array of strings is just not nice here
  • a tip function was added to tip plugin authors that have an offer in their manifest.json

Changelog-None

@vincenzopalazzo vincenzopalazzo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see that the manifest idea is taking over. Hope you are also using git for versioning, otherwise this would be another good thing to take from https://github.com/coffee-tools/coffee

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to reference the original reference implementation https://coffee-docs.netlify.app/support-coffee

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to reference the original reference implementation https://coffee-docs.netlify.app/support-coffee

I was planning on giving full credit for the manifest/tip function to coffee in the README. But i want to lock down the functionality first before writing documentation.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to save credit was also good to just include coffee, I do not think there are more features than coffee, we were also supporting ws (palanning to) to support interactive UX inside the web applications

But these days cloning is easy!

@daywalker90

Copy link
Copy Markdown
Collaborator Author

Nice to see that the manifest idea is taking over. Hope you are also using git for versioning, otherwise this would be another good thing to take from https://github.com/coffee-tools/coffee

If you mean installing a plugin with a git ref then yes, that is supported.

@vincenzopalazzo

Copy link
Copy Markdown
Collaborator

If you mean installing a plugin with a git ref then yes, that is supported.

Yeah, otherwise it's insanity! Nice, it would be nice to have two lines that reference coffee because the development died because Blockstream was moving to reckless. Referencing a good idea is what is left in this AI era, where rebuilding is easy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants