fix(tv): handle key repeat events for D-pad navigation - #2337
Open
usmanvrtx wants to merge 1 commit into
Open
Conversation
usmanvrtx
requested review from
TheNoumanDev
and removed request for
TheNoumanDev
August 6, 2026 20:38
usmanvrtx
marked this pull request as ready for review
August 6, 2026 20:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes TV D-pad navigation when the user holds down a key (auto-repeat).
Previously only
KeyDownEventwas handled, so repeated key events generatedwhile holding the D-pad button were ignored, causing slow/erratic scrolling and
navigation on TV remotes.
Related Issue
N/A
Type of Change
What Has Changed
_handleScopeKeyEventinTVFocusWidgetto also handleKeyRepeatEvent, so held D-pad keys continuously trigger back/scope navigation instead of only the initial pressonKeyEventhandler inTVScrollbarWidgetto also handleKeyRepeatEvent, enabling smooth continuous scrolling while the UP/DOWN key is heldHow to Test
flutter test modules/ensemble/test/widget/tv_scrollbar_widget_test.dartScreenshots / Videos
N/A
Checklist
flutter analyzeand addressed any new warningsflutter testand all tests pass