Repository navigation
fix(packaging): thin Postgres.app binaries and drop unshipped files - #384
Merged
Merged
Conversation
Release run 48 failed with "ENOENT: lstat packaging/electron/libicuuc.77.dylib". Postgres.app's ICU libraries record bare install names (libicuuc.77.dylib), and the relinker passed them to realpathSync, which resolved them against the build step's working directory. Resolve a non-absolute dependency next to the image that records it, and fail with a clear message if it is not there.
Inspecting the pinned Postgres.app 2.9.6 DMG showed three more relink failures waiting behind the ICU one: - Every Mach-O is universal (x86_64 + arm64). otool prints one block per slice, so the parsers read the slice headers as dependencies and library ids. Thin each file to the build architecture first. - Six static archives are universal too, so `file` calls them Mach-O. They are link-time only; remove them. - The PL/Python modules link /Library/Frameworks/Python.framework, which the runner does not have and Vision does not use. Remove them and their extension scripts.
EraPartner
enabled auto-merge (squash)
October 28, 2026 18:03
Coverage Report for backend
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#383 fixed the first relink failure in the v2.0.0 release build. I downloaded the pinned Postgres.app 2.9.6 DMG (SHA-256 matches
POSTGRES_APP_SHA256) and inspected its PostgreSQL 18 tree on Linux. That turned up three more failures queued behind the ICU one:otool -Landotool -Dprint one block per slice, solinkedLibrariesreads each slice header (the file's own staged path) as a dependency, anddynamicLibraryIdreads it as an executable's library id. The relinker now thins each file to the build architecture withlipobefore reading it..afiles are reported as Mach-O byfile. They are link-time only and are now removed from the staged runtime.plpython3.dyliband the three*_plpython3transforms link/Library/Frameworks/Python.framework/Python. The runner doesn't have it, and Vision doesn't use it: migrations only createpg_trgm,pgcryptoandpg_stat_statements. Those modules and their extension scripts are now removed.Also confirmed from the DMG:
pg_configreports PostgreSQL 18.6, which matchesPOSTGRES_VERSION.@loader_path. The only bare names are the ICU ones that fix(packaging): resolve bare ICU install names beside the source dylib #383 handles.Testing
bun run typecheck:electron, eslint and prettier pass.node --test packaging/electron/out/scripts/*.test.js: 49 pass, 1 skipped. That includes a new test for the file removal.Generated by Claude Code